New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove app.set('port', port); in express generator 4 #81
Comments
Can you explain how is it not supported in Express 4? Settings are just a bag of whatever you want. |
How is it utilised in the generated app? At the very least, it's superfluous. |
It's just a very common convention to know what port your app is on to provide links in your layouts. Adding that makes |
It was only added after tons and tons of requests for it; I'm not going to remove it and go through that again. If there is a PR you want to make to add more information to this line, or use it somewhere in the app, that would be accepted :) |
Add missing classes with transparent
Setting the port, like, `app.set('port', port), is not supported in express 4, so should be removed.
The text was updated successfully, but these errors were encountered: