Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is fileFilter really useful? #515

Closed
MolbioUnige opened this issue Aug 4, 2017 · 2 comments
Closed

Is fileFilter really useful? #515

MolbioUnige opened this issue Aug 4, 2017 · 2 comments

Comments

@MolbioUnige
Copy link

Sorry for asking this.

If I'm correct, the only fields present at fileFilter time are [ 'fieldname', 'originalname', 'encoding', 'mimetype' ]

One cannot rely on the originalname nor on the mimetype to check whether the file is what it pretends to be.

What is it that I am missing?
@LinusU
Copy link
Member

LinusU commented Aug 5, 2017

I agree, it's useless. That's why I have removed it in the 2.x alpha :) see #399 for more info 🎉

@LinusU
Copy link
Member

LinusU commented Aug 5, 2017

Closing this since we cannot remove it in 1.x (it would be a breaking change) and it's already removed in 2.x

@LinusU LinusU closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinusU @MolbioUnige