Fixes expressjs/multer#553 . Makes multer handle missing field names. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library. The current change allows getting an error from multer that makes it possible to handle it in servers.
ZloeSabo
force-pushed
the
fix/handle-missing-field-name
branch
from
c1ad9bb
to
97d3867
Compare
|
Any way to get that PR merged? Seeing this issue with our NestJS services :( |
|
Same here, though I first went with patching busboy: https://github.com/mscdex/busboy/pull/244/files I hesitated doing something similar in multer instead. That PR looks exactly like what I was looking for. |
|
Any news? |
LinusU
reviewed
Dec 7, 2021
LinusU
reviewed
Dec 7, 2021
LinusU
reviewed
Dec 7, 2021
|
Sorry for the very slow reply on this! Released as 1.4.4 🚀 |
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 21, 2022
Fixes expressjs#553 Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library. The current change allows getting an error from Multer that makes it possible to handle it in servers. Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
Fixes expressjs#553 Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library. The current change allows getting an error from Multer that makes it possible to handle it in servers. Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
Fixes expressjs#553 Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library. The current change allows getting an error from Multer that makes it possible to handle it in servers. Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
himanshiLt
pushed a commit
to himanshiLt/multer
that referenced
this pull request
Apr 26, 2022
Fixes expressjs#553 Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined" in the underlying append-field library. The current change allows getting an error from Multer that makes it possible to handle it in servers. Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix fields without a name result in a "TypeError: Cannot read property 'length' of undefined"
in the underlying append-field library.
The current change allows getting an error from multer that makes it
possible to handle it in servers.
See #553