Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest config #87

Closed
3 of 5 tasks
Amorim33 opened this issue Sep 6, 2023 · 0 comments · Fixed by #88
Closed
3 of 5 tasks

Add vitest config #87

Amorim33 opened this issue Sep 6, 2023 · 0 comments · Fixed by #88
Assignees
Labels
enhancement New feature or request

Comments

@Amorim33
Copy link
Contributor

Amorim33 commented Sep 6, 2023

Description

We need automated tests as soon as possible in the core. Tests ensure not only quality but also accelerate development, a strong culture of automated testing makes the team more agile and with more bug-free deliveries.

We already have some tests ( e.g. https://github.com/expressots/expressots/blob/main/packages/core/test/application.spec.ts), but they are not running correctly.

The goal of this issue is to fix the config and enable tests to run, it also should use Vitest instead of Jest, they are almost the same in terms of syntax. However, Vitest is much faster.

Ref.
https://vitest.dev/
https://vitest.dev/config/
https://dev.to/mbarzeev/from-jest-to-vitest-migration-and-benchmark-23pl

Requirements

  • vite and vitest must be listed in the project references;
  • all tests must run;
  • tests must run in the CI.

Definition of Done

  • assert that tests are running correctly using vitest;
  • assert that the action is correctly running in the PR.
@Amorim33 Amorim33 self-assigned this Sep 6, 2023
@Amorim33 Amorim33 added enhancement New feature or request and removed enhancement New feature or request labels Sep 6, 2023
@rsaz rsaz closed this as completed in #88 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant