Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Run Magento Coding Standard check on changed files #106

Closed
tuyennn opened this issue Nov 7, 2023 · 2 comments
Closed

[Question] Run Magento Coding Standard check on changed files #106

tuyennn opened this issue Nov 7, 2023 · 2 comments

Comments

@tuyennn
Copy link

tuyennn commented Nov 7, 2023

Hi, folks
I'm currently got an idea to run the extdn/github-actions-m2/magento-coding-standard on changed list files, example in a pull request.

Any help would be appreciated.

@sprankhub
Copy link
Collaborator

That was pretty much implemented here: https://github.com/mage-os/github-actions/tree/main/coding-standard-baseline
And is used here: https://github.com/mage-os/mageos-magento2/blob/2.4-develop/.github/workflows/coding-standard-baseline.yml

This can give you an idea. However, these actions are currently still very much targeted to mage-os/mageos-magento2 - I am not sure if you can run those on your code base.

If you do not have a huge code base, the phpcs check should run fast anyway, though?

@tuyennn
Copy link
Author

tuyennn commented Nov 7, 2023

@sprankhub happy to see your quick reply.
Indeed this is detail https://github.com/mage-os/github-actions/blob/main/coding-standard-baseline/action.yml
Just invest some experiments on my personal projects, and they are not so big.

@tuyennn tuyennn closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants