Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuration of composer version in integration tests #40

Merged

Conversation

kolaente
Copy link
Contributor

@kolaente kolaente commented Oct 8, 2021

This PR provides a way to configure the composer version used in integration tests.

Composer 2 was only installed in the Dockerfile for 7.4 so I added the config option only there. IIRC composer 2 requires 7.4? (or at least 7.3?)

@fooman
Copy link
Contributor

fooman commented Oct 11, 2021

@kolaente this looks good to me but just to confirm that I read it right, this would not break any existing scripts that use composer without version suffix as we symlink the 1 version on start up?

@damienwebdev
Copy link

This needs to be shared across to PHPStan as well since they use the same version under the hood.

@kolaente
Copy link
Contributor Author

@fooman Yes, it should break any existing scripts.

@kolaente
Copy link
Contributor Author

@damienwebdev That's probably the time when we should put the effort in to create a base image that lets you switch between versions. See #25 (comment)

@sprankhub
Copy link
Collaborator

Very good change! Thanks @kolaente! However, given that Composer 1 is really EOL, I suggest switching the default to version 2 even if this is a breaking change in some cases.

@jissereitsma
Copy link
Contributor

Sorry for the long delay. Just to reiterate the statement of @kolaente - he mentioned that it "should break" but I think that was a typo so I interpret it as "should not break". Looking at the change, I think this is safe to adopt. If it break, let's fix it. If it works, let's implement it elsewhere.

@jissereitsma jissereitsma merged commit 52b783c into extdn:master Dec 10, 2021
@kolaente kolaente deleted the feature/integration-tests-composer-2 branch December 10, 2021 11:24
@kolaente
Copy link
Contributor Author

he mentioned that it "should break" but I think that was a typo so I interpret it as "should not break".

oh yes, that's definitely a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants