Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use PHP 7.4 action for coding standards #43

Closed
schmengler opened this issue Oct 25, 2021 · 5 comments · Fixed by #44
Closed

Cannot use PHP 7.4 action for coding standards #43

schmengler opened this issue Oct 25, 2021 · 5 comments · Fixed by #44

Comments

@schmengler
Copy link

I'm trying to use PHP 7.4 for the coding standards action with the following yml file

 name: ExtDN M2 Coding Standard
 on:
   push:
     branches:
       - master
   pull_request:
 
 jobs:
   static:
     name: M2 Coding Standard
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: extdn/github-actions-m2/magento-coding-standard/7.4@master

Which errors with:

Pull down action image 'extdn/magento-coding-standard-action:7.4-latest'
  /usr/bin/docker pull extdn/magento-coding-standard-action:7.4-latest
  Error response from daemon: manifest for extdn/magento-coding-standard-action:7.4-latest not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 9.014 seconds before retry.
  /usr/bin/docker pull extdn/magento-coding-standard-action:7.4-latest
  Error response from daemon: manifest for extdn/magento-coding-standard-action:7.4-latest not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 8.851 seconds before retry.
  /usr/bin/docker pull extdn/magento-coding-standard-action:7.4-latest
  Error response from daemon: manifest for extdn/magento-coding-standard-action:7.4-latest not found: manifest unknown: manifest unknown
Error: Docker pull failed with exit code 1

(without /7.4 it works but cannot parse PHP 7.4 syntax obviously)

@torhoehn
Copy link

Just discovered the same issue.

@jissereitsma
Copy link
Contributor

Reopening the issue, because the PR was merged but the issue is not fixed yet.

@jissereitsma
Copy link
Contributor

Could you retest this? It should be working now.

@torhoehn
Copy link

@jissereitsma Looks good for me now, thank you!

@jissereitsma
Copy link
Contributor

I'm closing this issue as of yet, because we have 2 reports that this is working now. Let me know if this is not working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants