Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 support for PHPStan #68

Closed
jissereitsma opened this issue May 3, 2022 · 3 comments
Closed

Add PHP 8.1 support for PHPStan #68

jissereitsma opened this issue May 3, 2022 · 3 comments
Assignees

Comments

@jissereitsma
Copy link
Contributor

Add PHP version infrastructure similar to the approach with unit tests and integration tests. Add PHP 8.1, following from that. Make sure that the workflows in this repository are also picking up on new commits and/or PRs, so that Docker images are built automatically. Ask @sprankhub to do the work.

@sprankhub
Copy link
Collaborator

Nice try, @jissereitsma 😅

Make sure that the workflows in this repository are also picking up on new commits and/or PRs, so that Docker images are built automatically.

At least this should be fixed already. Images are built automatically already on new relevant pushes.

@jissereitsma jissereitsma self-assigned this May 3, 2022
@jissereitsma
Copy link
Contributor Author

The PHPStan GitHub Action is updated to include a PHP version. Little sample:

name: ExtDN M2 PHPStan
on: [push, pull_request]

jobs:
  phpstan:
    name: M2 PHPStan
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: extdn/github-actions-m2/magento-phpstan/8.1@master
        with:
          composer_name: ${{ secrets.COMPOSER_NAME }}

Mainly the action usage of extdn/github-actions-m2/magento-phpstan@master should switch to extdn/github-actions-m2/magento-phpstan/8.1@master (or PHP 7.3 or PHP 7.4).

@jissereitsma
Copy link
Contributor Author

Self-closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants