-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monolog 2.7 causes breaking changes that make Integration Tests fail #72
Comments
/cc @damienwebdev |
Note that 2.8 will still include this change :) My own Magento issue is a duplicate. I'll close it right away. |
Added for now like this: 1cc6ce6 |
@jissereitsma Yeah agreed that 2.8 monolog will still include this change my thoughts were
This was to hopefully prevent against weird scenarios in future where I've locked to 2.6.0 but need higher, honestly as well to keep it painful a little bit. Don't want to forget this is an issue that needs handled :p |
@convenient I definitely like the approach of asking for feedback on the comment that Jordi (Seldaek) made, but I'm actually not sure if anyone will pick up on this. It might very well be that the person know built this in the past, moved on already. A handler is a better idea indeed. I already refactored a couple of things in my dev environment to allow for this. But I'm also just wondering who is using this logging ability. Plus I read that in PHPUnit 10 the logger listening feature is actually going to be removed :o |
In my environment, Magento 2.4.4 with PHP 8.1 causes the installation of Monolog 2.7, which again has changed method signatures that are used by the Magento TestFramework to log stuff. This issue is reported at Magento here: magento/magento2#35720
The workaround is to add
composer require monolog/monolog:2.6.0
somewhere to the Integration Tests, right before doing acomposer install
. I've personally added it to a pre-install script.Anyone else bumping into this? If so, I might simply add it to the GitHub Action here instead.
The text was updated successfully, but these errors were encountered: