Autodetect CT SUITES #78
Conversation
|
Almost. The suite name in CT_SUITES still must not include _SUITE. Otherwise yes, definitely yes. That's one point that needed to be done for 1.0. On the other hand once the above change is done it will also need to be done in plugins/ct.mk for the new version (can be tested by generating it using 'make'). |
|
Any particular reason for needing to remove the _SUITE part? I tried it and it seems to work anyway. I can still look into doing it if you want. |
|
I modified my change to do |
|
There now it extracts the module name from the tests in both the old and new setup. I also updated the documentation to mention the autodetection. Is there anything else you need from me for this PR? =) |
| then you only need to put `ponies` in the list. | ||
| then you only need to put `ponies` in the list. This is usefull if you | ||
| need erlang.mk to skip some tests as the default is to autodetect your | ||
| common_test suites. |
There was a problem hiding this comment.
Let's keep the first sentence, say what the default is in the second sentence, and then explain how to override the default in the third sentence.
|
Still need the docs change and we're good to merge. |
|
See if you like that better =) |
|
There's a typo! And then squash the commits and we're good. Thanks! |
| @@ -232,7 +232,7 @@ CT_RUN = ct_run \ | |||
| -dir test \ | |||
| -logdir logs | |||
|
|
|||
| CT_SUITES ?= | |||
| CT_SUITES ?= $(subst _SUITE.erl,,$(shell find test -type f -name \*_SUITE.erl -exec basename {})) | |||
There was a problem hiding this comment.
My bad, this here needs the ; at the end or -exec can't find its argument. Please put it back.
|
Also would be better to sort the suites by alphabetical order, they're not sorted at all right now. |
|
Now it sorts as well. |
|
Right but you need to put ; back in again, you removed it somehow. |
|
ah, missed your comment about needing it. will fix tonight. |
|
There semicolons are back. |
|
And merged, thanks! |
|
You introduced a bug if test doesn't exist: find: `test': No such file or directory Please send a fix! |
This change should enable autodetection of CT Suites. I have tried it on one personal project and it seems to work.