Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bump.sh and publish.sh for new crate structure #70

Closed
clauswilke opened this issue Dec 10, 2020 · 8 comments · Fixed by #82
Closed

Fix bump.sh and publish.sh for new crate structure #70

clauswilke opened this issue Dec 10, 2020 · 8 comments · Fixed by #82
Milestone

Comments

@clauswilke
Copy link
Member

I have added a new crate extendr-engine (#50) to remove the engine part from the default api. However, the scripts bump.sh and publish.sh don't reflect this change yet.

@clauswilke clauswilke added this to the 0.1.11 milestone Dec 10, 2020
@clauswilke clauswilke mentioned this issue Dec 10, 2020
10 tasks
@andy-thomason
Copy link
Contributor

Claus has suggested bumping the version right after the publish. This will help us to distinguish versions that are pulled from github.

@clauswilke
Copy link
Member Author

I like the versioning recommendations in the R packages book, which is to add a dev version (e.g., .9000) right after a package has been published, and then bump to the next non-dev version upon release. Is this possible with the Rust versioning system?

@clauswilke
Copy link
Member Author

I think in Rust we have to go 0.1.10 -> 0.1.11-alpha -> 0.1.11 instead of 0.1.10 -> 0.1.10.9000 -> 0.1.11.

https://docs.rs/semver/0.11.0/semver/

@clauswilke
Copy link
Member Author

Or maybe we should just delete these two scripts and transition to cargo workspaces:
https://crates.io/crates/cargo-workspaces

cargo workspaces version can bump versions.

cargo workspaces publish can publish to crates.io.

@yutannihilation
Copy link
Contributor

cargo workspaces version can bump versions.

Sorry, I forgot to comment that this doesn't handle the versions specified with path. So we need some tweaks about these lines:

extendr-macros = { path = "../extendr-macros", version="0.1.11" }
extendr-engine = { path = "../extendr-engine", version="0.1.11" }

Btw, be careful when you try this command as this immediately commits and pushes the new version to remotes... When I tried this, I wasn't the member of extendr so the attempt was just rejected... --no-git-commit seems to save us.

@clauswilke
Copy link
Member Author

If you have some experience with this tool, could you write up a workflow and add to the README, where it currently talks about bump.sh and publish.sh?

@yutannihilation
Copy link
Contributor

After experimenting a bit more, I think cargo workspaces version is currently broken. I'll try to fix it there, but I'm not sure if it gets done before the next release.

@yutannihilation
Copy link
Contributor

Sorry, it turned out it's just I didn't understand the usage... I think I can write up a workflow soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants