Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set SystemRequirements field automatically #298

Merged
merged 5 commits into from Jul 1, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jun 27, 2023

Currently a message to notice this field (Please update the system requirement in 'DESCRIPTION' file.), but I do not think there is any disadvantage to setting it up automatically.

The notation SystemRequirements: Cargo (rustc package manager) has been used in gifski, hellorust etc.
https://github.com/cran/gifski/blob/8bc440a1e3921af1f37a0deb27a01b8274d9b138/DESCRIPTION#L16
https://github.com/cran/hellorust/blob/2265950f01f2bbd87bab26c4f242b9fa8c9817dc/DESCRIPTION#L17

@eitsupi eitsupi marked this pull request as ready for review June 27, 2023 06:53
@CGMossa
Copy link
Member

CGMossa commented Jun 27, 2023

Another great idea. However, this is a "cran" / free field, and could contain
a number of things. Some packages include that you need GNUMake to compile a package.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 27, 2023

However, this is a "cran" / free field, and could contain
a number of things. Some packages include that you need GNUMake to compile a package.

Of course, I understand that and therefore will not overwrite it if SystemRequirements has already been set. This is as confirmed by the test.

@eitsupi
Copy link
Contributor Author

eitsupi commented Jul 1, 2023

Is there any reason this can't be merged?

Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should I merge right now or do you have anything else to modify?

@eitsupi
Copy link
Contributor Author

eitsupi commented Jul 1, 2023

Thank you for your review. I think you can merge this one right away.

@Ilia-Kosenkov Ilia-Kosenkov merged commit 972ab2c into extendr:main Jul 1, 2023
17 checks passed
@eitsupi eitsupi deleted the desc-sysreqs branch July 1, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants