Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sequences — sequence<T> type #22

Open
marcoscaceres opened this issue Jan 7, 2013 · 5 comments
Open

Implement Sequences — sequence<T> type #22

marcoscaceres opened this issue Jan 7, 2013 · 5 comments
Assignees

Comments

@marcoscaceres
Copy link
Contributor

http://www.w3.org/TR/WebIDL/#idl-sequence

@ghost ghost assigned marcoscaceres Jan 7, 2013
@marcoscaceres
Copy link
Contributor Author

Started work in parallel with Array, as they depend on each other.

@marcoscaceres
Copy link
Contributor Author

WebIDL spec seems wrong. Filed bug against spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=20731

@FremyCompany
Copy link
Contributor

For people coming to the thread only now, the issue has been resolved and the algorithm of the spec is indeed correct. The question was about

obj["0"] vs obj[0] 

(officially, property names are always strings in ES5 so the WebIDL spec converts integers to strings; actually we should not do that because browser do not really use string indexes on array, but this only got standardized in ES6).

@marcoscaceres
Copy link
Contributor Author

yeah, I didn't know that [x] becomes [String(x)] internally. Things one learns :) I also learned not to file bugs until AFTER I have actually implemented and tested.

@marcoscaceres
Copy link
Contributor Author

I've got this implemented (it's in the currently in the Array type branch). However, as we don't have all the types yet, it's not possible to fully test. Regardless, the base functionality is going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants