Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

RFE: add support to "controller.ingressClass"-like annotations #438

Closed
marcuz opened this issue Jul 14, 2020 · 3 comments
Closed

RFE: add support to "controller.ingressClass"-like annotations #438

marcuz opened this issue Jul 14, 2020 · 3 comments
Labels
enhancement New feature or request Stale

Comments

@marcuz
Copy link

marcuz commented Jul 14, 2020

Hello,

in our use-case we are fetching secrets from AWS Secrets Manager $region1, but we also have the need of fetching some of them from $region2.
We are working it around having 2 instances of external-secrets running, but they are both consistently failing to fetch the secret from the other region - which is expected.

Would it make sense to consider adding an annotation-driven mechanism similar to what Ingress is doing, as in watching not only per-namespace (as discussed in #106) but also "filtering responsibilities" of each external-secret instance?

@Flydiverny Flydiverny added the enhancement New feature or request label Jul 14, 2020
@moolen
Copy link
Member

moolen commented Sep 4, 2020

The region feature is discussed in #354, i think that should fix your issue (PR is open). Nonetheless having a ingressClass is a good idea and is a valid use-case to shard responsibility (also its part in an attempt to standardize the crd spec #477 ).

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jan 29, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

This issue was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this as completed Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants