Deprecation: apiextensions.v1beta1 removed in 1.22

[afirth]

Maybe I'm missing something - I guess this is going to blow up on new installs soon?

kubernetes-external-secrets/lib/custom-resource-manager.js

Line 29 in 190e6db

.v1beta1

[Flydiverny]

If by blow up on new installs you mean won't work in v1.22 or newer once they land, then yes.

Regardless the built in CRD management is deprecated and should probably be removed before this is even an issue.
But even so the CRD resources need to be updated.

PRs welcome

[afirth]

Ah, I thought it was deprecated in 1.16 and not served in 1.19+ based on https://github.com/kubernetes/kubernetes/blame/master/CHANGELOG/CHANGELOG-1.16.md#L1623 . But indeed it did a permabeta kubernetes/kubernetes#90673. Shall I close this if it's getting ripped out anyway? And, since I was about to install it with the CRD manager, is that not recommended? I couldn't really find any doco about the CRD manager. Appreciate the pointers.

Re PR, not a language I know well, but I guess clarity as to whether it should be removed or fixed might help a future contributor.

[Flydiverny]

KES did install its CRD once the server started, and still does. Not sure what the design decision behind that was.
When support for helm 3 was added a flag was added to allow disabling the built in CRD management and just installt he CRD resources with helm. So passing --set customResourceManagerDisabled=true to helm should disable the built in management.

https://github.com/external-secrets/kubernetes-external-secrets/blob/master/charts/kubernetes-external-secrets/README.md#installing-the-crd

Its on my todo list to try and clean it up and remove any helm 2 things, when time permits 😄 hopefully making it less confusing.

We can leave this open as a reminder for the CRD resources