Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Support Azure China Cloud #745

Closed
goldginkgo opened this issue May 12, 2021 · 3 comments
Closed

Support Azure China Cloud #745

goldginkgo opened this issue May 12, 2021 · 3 comments
Labels
azure enhancement New feature or request Stale

Comments

@goldginkgo
Copy link

goldginkgo commented May 12, 2021

The kubernetes-external-secrets seems to be not working with Azure China Cloud.
According to Azure documentation https://docs.microsoft.com/en-us/azure/key-vault/general/security-features#privileged-access, Azure China has different endpoints.

Global:
<vault-name>.vault.azure.net:443

Azure China 21Vianet:
<vault-name>.vault.azure.cn:443

But from the code, it is only pointing to the Azue global endpoint https://github.com/external-secrets/kubernetes-external-secrets/blob/master/lib/backends/azure-keyvault-backend.js#L20.

Is there any workaround for this?

Thanks.

@moolen
Copy link
Member

moolen commented Jun 14, 2021

That's not possible yet, but really easy to configure as you have found out already (same issue as #764 )

@moolen moolen added azure enhancement New feature or request labels Jun 14, 2021
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 13, 2021
@github-actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants