Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

CRD property types #758

Merged

Conversation

davidholsgrove
Copy link
Contributor

@davidholsgrove davidholsgrove commented May 24, 2021

Closes #753

The empty properties here also produces invalid json schema when used with https://github.com/yannh/kubeconform

Provide types for each property in oneOf

The empty properties here also produces invalid json schema when used with https://github.com/yannh/kubeconform
@davidholsgrove davidholsgrove changed the title Closes #753 CRD property types May 24, 2021
@davidholsgrove davidholsgrove marked this pull request as draft May 24, 2021 06:32
@davidholsgrove davidholsgrove marked this pull request as ready for review May 24, 2021 06:44
@caretak3r
Copy link

This is also currently an issue with us using the latest (8.0 and 8.0.1). Bump ^

@davidholsgrove
Copy link
Contributor Author

Could this PR (or any alternative to address #753 ) be reviewed / merged before the next cut of external-secrets?

@Flydiverny Flydiverny merged commit fa54f54 into external-secrets:master Jun 3, 2021
@davidholsgrove davidholsgrove deleted the crd-property-types branch June 3, 2021 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRD empty properties breaking intellij parsing (cause of empty properties)
3 participants