Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle specific paypal error codes #303

Closed
syjer opened this issue Jul 17, 2017 · 1 comment
Closed

handle specific paypal error codes #303

syjer opened this issue Jul 17, 2017 · 1 comment
Assignees
@syjer
Projects
1.12
Milestone
1.12

Comments

@syjer
Copy link
Member

syjer commented Jul 17, 2017

Some error code from paypal like "INSTRUMENT_DECLINED" would benefit with a custom error message.

The following erors code have been identified as an interesting target:

  • INSTRUMENT_DECLINED
  • FAILED_TO_CHARGE_CC
  • INSUFFICIENT_FUNDS
  • EXPIRED_CREDIT_CARD
@syjer syjer added this to the 1.12 milestone Jul 17, 2017
@syjer syjer self-assigned this Jul 17, 2017
syjer added a commit that referenced this issue Jul 17, 2017
@syjer
#303 map paypal error code to user friendly message
eb13ca6
@syjer
Copy link
Member Author

syjer commented Jul 17, 2017

Will require the following translations/messages:

  • INSTRUMENT_DECLINED
  • INSUFFICIENT_FUNDS

cbellone pushed a commit that referenced this issue Jul 25, 2017
@syjer @cbellone
#303 map paypal error code to user friendly message
f3d24a3 
(cherry picked from commit eb13ca6)
cbellone added a commit that referenced this issue Jul 25, 2017
@cbellone
#303 update messages
ba483b3
cbellone added a commit that referenced this issue Jul 25, 2017
@cbellone
#303 update messages
c3854bb 
(cherry picked from commit ba483b3)
@syjer syjer added this to In progress in 1.12 Aug 2, 2017
@cbellone cbellone closed this as completed Sep 6, 2017
@cbellone cbellone moved this from In progress to Done in 1.12 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
None yet
Projects
No open projects
1.12
Done
Milestone
1.12
Development

No branches or pull requests
2 participants
@syjer @cbellone