Refactor java-sdk #136
Refactor java-sdk #136
Conversation
thomasdarimont
force-pushed
the
poc/revise-java-sdk
branch
from
16265fd
to
ec106e2
Compare
|
@bhelx I just gave this another spin and refactored the library to be a bit. Hope this meets your expectations. :) I think we could also lower the required Java version to Java 17. |
|
Hey @thomasdarimont we seem to be simultaneously working on the same stuff today. Happy to take your changes many of them look better than mine. If you want to take on some of the rest of the work though let me know so I don't step on your toes. Happy to have you lead here! :) |
🥳 |
yeah let's go as low as we can safely go! |
|
Let me know if you want to resolve the conflicts or me. I think it's safe to say I prefer your changes. |
|
Sorry for the overlap. I'll try to merge it quickly. |
- Make Plugin and Context AutoClosable to automatically free resources in TWR blocks - Add missing javadoc - Upgrade to Junit 5 - Reorganize packages - Use more meaningful names - Introduce ExitsmException - Make JSON serialization pluggable Improves extism#117
thomasdarimont
force-pushed
the
poc/revise-java-sdk
branch
from
ec106e2
to
b419045
Compare
|
@bhelx I just finished the merge. I reused most of your JavaDoc comments and added some convenience methods. I saw that you made some methods protected, for which I wasn't sure whether they are intended for internal usage or usage by subclasses. Feel free to adapt the code to your liking :^) |
|
Thanks again! Is there anything else you had planned on working on? I actually think it's pretty close to being good for a release. I'm gonna setup CI and publishing next. If you have anything you're interested in doing let me know. |
|
Thanks @bhelx for the quick turnaround :) I just added some additional remarks on the java-sdk PR. |
- Refactor Plugin - Make `Plugin` and `Context` `AutoClosable` to automatically free resources in TWR blocks - Add missing javadoc - Upgrade to Junit 5 - Reorganize packages - Use more meaningful names - Introduce `ExtismException` - Make JSON serialization pluggable - Lower required java version to Java 17 Improves extism#117
PluginandContextAutoClosableto automatically free resources in TWR blocksExtismExceptionImproves #117