Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext.Net.TabPanel event parameters didn't match ExtJS #1403

Closed
fabriciomurta opened this issue Dec 15, 2016 · 1 comment
Closed

Ext.Net.TabPanel event parameters didn't match ExtJS #1403

fabriciomurta opened this issue Dec 15, 2016 · 1 comment
Assignees
Milestone

Comments

@fabriciomurta
Copy link
Contributor

fabriciomurta commented Dec 15, 2016

Found: 3.3.0
Forum thread: beforetabchange. minor doc issue.

Ext.Net.TabPanel events (direct events and listeners) have parameters called Tab where they should be named Card. For example, beforetabchange has newTab and oldTab, while current and corresponding Sencha documentation reports newCard and oldCard, respectively.

Documentation for ExtJS 5.1.2 and 5.1.3 match the prototype.

  • 4.1.3 and 4.2.5 also shows newCard
  • 4.0.0 shows newCard
  • 3.4.0 shows newTab and currentTab.

The problem about "fixing" this is the introduction of a breaking change.

@fabriciomurta
Copy link
Contributor Author

Also added comments to ext.net specific events.

@fabriciomurta fabriciomurta self-assigned this Dec 15, 2016
@geoffreymcgill geoffreymcgill changed the title Ext.Net.TabPanel event parameters don't match ExtJS documentation Ext.Net.TabPanel event parameters didn't match ExtJS Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant