Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ext.net.HyperlinkButton component's toggle() function to toggleEnabled() #1449

Closed
fabriciomurta opened this issue Mar 21, 2017 · 1 comment

Comments

@fabriciomurta
Copy link
Contributor

The function in Ext.NET context will toggle the enabled state of the button. It now conflicts with Ext.button.Button which calls it on click!..

To avoid a breaking change, #1448 makes it take different behavior according to the caller:

  • whenever it is Ext.button.Button.doToggle(), call parent toggle() (if any)
  • whenever else, does its usual enabled state toggle.
@fabriciomurta
Copy link
Contributor Author

Function renamed to toggleEnabled() instead.

So, to implement the fix, server-side method ToggleEnabled() was introduced, and client-side toggleEnabled() function was renamed, from toggle() that was present in the Ext.net.HyperlinkButton definition.

As the Hyperlink button inherits from the simple button, then it gets the toggle() client and server side methods.

@fabriciomurta fabriciomurta changed the title Rename Ext.net.HyperlinkButton.toggle() function Rename Ext.net.HyperlinkButton component's toggle() function to toggleEnabled() Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant