Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext.ux.desktop.Desktop.setShortcutPosition() lets desktop move shortcuts back on resize #1558

Closed
fabriciomurta opened this issue Oct 4, 2017 · 1 comment
Milestone

Comments

@fabriciomurta
Copy link
Contributor

Found: 4.4.1
Ext.NET forum thread: Desktop - arrange shortcuts

If shortcuts in desktop are arranged via its setShortcutPosition(), also called by Ext.ux.desktop.Desktop.arrangeShortcuts(true), and then the window is resized, the following arrangeShortcuts(false) call that happens once resizing the browser window will move the shortcuts back to their initial position.

There are two lines of code commented out from desktop code but there are no explanation as for why where they commented out, so this override addresses the issue:

Ext.define("gh1558", {
    override: "Ext.ux.desktop.Desktop",
    setShortcutPosition: function (record, height, col, row, view) {
        var me = this,
            retVal = me.callParent(arguments);

        record.data.x = record.data.tempX;
        record.data.y = record.data.tempY;

        return retVal;
    }
});

As this method is defined in Ext.NET overrides/customization for the Desktop component itself, then this shouldn't be an issue related to Sencha.

@fabriciomurta fabriciomurta added this to the 4.5.0 milestone Oct 4, 2017
@geoffreymcgill geoffreymcgill modified the milestones: 4.5.0, 4.x Oct 11, 2017
@fabriciomurta
Copy link
Contributor Author

Fixed by un-commenting the code in desktop overrides that would do what it takes to address the issue. There were no documentation/history on why the lines were commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants