Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

<S-CR> keybinding isn't working #642

Closed
volny opened this issue Aug 22, 2017 · 3 comments
Closed

<S-CR> keybinding isn't working #642

volny opened this issue Aug 22, 2017 · 3 comments
Labels
bug help wanted
Milestone
0.2.9

Comments

@volny
Copy link

volny commented Aug 22, 2017

I use shift-enter instead of enter to insert a new line.
inoremap <S-CR> <NL> is ignored and not working. As a sidenote inoremap <C-CR> <NL> works as expected.
@bryphe bryphe modified the milestones: 0.3, 0.2.9 Aug 22, 2017
@bryphe
Copy link
Member

bryphe commented Aug 22, 2017

Thanks for isolating and logging the issue, @volny ! I'm able to reproduce this. It's interesting that works - I wonder if we aren't mapping the shift case correctly here in Keyboard.ts.

This was referenced Aug 23, 2017
Closed
Merged
@justjoeyuk
Copy link
Contributor

@volny The latest PR should solve the problem 😄

bryphe pushed a commit that referenced this issue Aug 29, 2017
@justjoeyuk
FIXED ISSUE #642 - ADDED missing mappings (#652)
074189c 
* ADDED missing mappings

* corrected minor typo (#648)

similiar -> similar

* Fix config file location in README (#650)

Support for `config.json` was removed in e7e1435.

* refactor menu.js (#656)

Refactor menu list like sublime/atom

* ADDED missing mappings

* FIXED binding for command palette

* REMOVED preventDefault
@keforbes
Copy link
Collaborator

Fixed by #652.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
0.2.9
Development

No branches or pull requests
4 participants
@keforbes @justjoeyuk @volny @bryphe