Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix commit hooks on windows (+tests) #14

Closed
extrawurst opened this issue Apr 9, 2020 · 7 comments
Closed

fix commit hooks on windows (+tests) #14

extrawurst opened this issue Apr 9, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@extrawurst
Copy link
Owner

extrawurst commented Apr 9, 2020 •
edited

calling the hooks is currently only implemented of *nix systems.
how does this even work on windows? does git call *.bat files? help of someone on a windows machine would be required here.
@extrawurst extrawurst added the bug Something isn't working label Apr 9, 2020
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed bug Something isn't working labels May 12, 2020
@MCord
Copy link
Contributor

MCord commented May 15, 2020

I can take this if it's ok with you.

@extrawurst
Copy link
Owner Author

extrawurst commented May 15, 2020 •
edited

Absolutely! Are you running on windows? I have a hard time even testing this being on a Mac. Do you know how hooks work on windows? are they expected as *.bat files?

@MCord
Copy link
Contributor

MCord commented May 15, 2020

yes I use a windows 10 as my main machine. for hooks on windows you have to specify an alternative interpreter. the default installation of git provides a bash interpreter but even PowerShell should work.

@extrawurst
Copy link
Owner Author

Ok I assume its regular bash scripts aswell, now that I look at it.

@MCord could you add a unitest for the hooks, I realize they are missing

@extrawurst
Copy link
Owner Author

I tried to reach out to you twitter. would you be up for syncing on discord?

@MCord
Copy link
Contributor

MCord commented May 15, 2020

That would be great ! let me know when you are available to chat!

@MCord
Copy link
Contributor

MCord commented May 15, 2020 •
edited

my handle is mcord#0935 on discord by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@extrawurst @MCord