Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search/filter commit(s) #1791

Closed
extrawurst opened this issue Aug 5, 2023 · 6 comments · Fixed by #1800
Closed

search/filter commit(s) #1791

extrawurst opened this issue Aug 5, 2023 · 6 comments · Fixed by #1800

Comments

@extrawurst
Copy link
Owner

extrawurst commented Aug 5, 2023

We want to substring / fuzzy search for

  • commit sha (or parts of it),
  • authors fields
  • commit message
  • filenames appearing in diff
  • content of diffs

fixes #449, #429, #1790

Note: Fuzzy does not mean realtime in this case. It means we do not need perfect matching, mostly relying on fuzzy_matcher

@AmmarAbouZor
Copy link
Contributor

SHA

I think we can at first separate using sha from the rest because it's one to one search (each sha will give one commit only).
For that I would suggest a "jump to commit" function which opens an input box with a keybinding to past from the system clipboard then when it's applied the commit will be selected if found or some message can be shown

Filter/Fuzzy Matches

I think there is a trade off we need to make here...

  • Live fuzzy matches is more intuitive and easier to use but it needs all the data to be loaded in memory so it will not give misleading information.
  • A "classic" Filter function: Filter popup with the wanted options >> apply the filter to show only the commits that meet the filter criteria. This approach isn't as intuitive as the fuzzy matches one but it comes with less overhead since we don't need to have all the data in memory and the filtering will be applied only once and not with each keystroke.

@bewlay

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@bewlay

This comment was marked as resolved.

@extrawurst
Copy link
Owner Author

@AmmarAbouZor your comment lead me to split out a separate issue for this particular use case: #1799

@extrawurst extrawurst added this to the v0.24 milestone Aug 9, 2023
This was referenced Aug 9, 2023
@Rodrigodd
Copy link
Contributor

Recently (a month ago, actually) I have opened the PR #1753, that finish the work done by #506 and #672. That PR implements searching by sha, author, message and tag, including controls for each one, but not in a fuzzy way.

I am not sure if you @extrawurst missed it, or it just isn't relevant for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants