Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separator to visualize commit message from extended description #652

Closed
alexherbo2 opened this issue Apr 21, 2021 · 5 comments · Fixed by #662
Closed

Add a separator to visualize commit message from extended description #652

alexherbo2 opened this issue Apr 21, 2021 · 5 comments · Fixed by #662
Labels
bug Something isn't working
Milestone

Comments

@alexherbo2
Copy link

In the log view, we see the following commit message:

Update README

Extended description

as:

Update READMEExtended description

It could be nice to render as:

Update README┊Extended description
@extrawurst
Copy link
Owner

That actually looks like a bug.

@extrawurst extrawurst added the bug Something isn't working label Apr 21, 2021
@extrawurst extrawurst added this to the v0.15 milestone Apr 21, 2021
@alexherbo2
Copy link
Author

I liked to see whether a commit had an extended message. We could easily see references and spot auto-squashed messages.

@extrawurst
Copy link
Owner

@alexherbo2 that would be a new feature, please open a new issue with a suggestion how to indicate that

@alexherbo2
Copy link
Author

Not sure how it differs from Add a separator to visualize commit message from extended description.

I mean I was happy before, just a separator would have been enough. xd

@extrawurst
Copy link
Owner

before #662 it was a bug, I dont know when this was introduced but the expected behaviour was that only the subject line is shown in the commit log.

what you want is a feature and has less priority and also needs a concept of how to visualise, so its a less low hanging fruit and requires a dedicated issue, which I would label good first issue and see if anyone picks it up. if you like feel free to create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants