Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show symbol if tag is not yet pushed #776

Merged

Conversation

cruessler
Copy link
Contributor

This partly addresses #742.

Let me know whether I put the async code in the right place or whether you’d like it moved to a different location!

gitui-tags-remote-indicator

@extrawurst
Copy link
Owner

Screenflick Movie 29

this does not seem to work quiet yet I am afraid. if I tag a commit and open the tags popup it does not show the new symbol

@cruessler cruessler force-pushed the show-symbol-if-tag-not-on-remote branch from 03831db to f7c1aad Compare June 9, 2021 13:26
@cruessler
Copy link
Contributor Author

@extrawurst Is this possibly related to authentication being necessary? To test this hypothesis, I updated the PR to call extract_username_password and pass the result to tags_missing_remote (previously, None was passed instead). Can you try whether this has an effect on your machine?

@extrawurst
Copy link
Owner

extrawurst commented Jun 9, 2021

@extrawurst Is this possibly related to authentication being necessary? To test this hypothesis, I updated the PR to call extract_username_password and pass the result to tags_missing_remote (previously, None was passed instead). Can you try whether this has an effect on your machine?

nope that did not fix it. I suspect its related to the fact that you only ever set the missing_remote_tags once and then never again

@cruessler cruessler force-pushed the show-symbol-if-tag-not-on-remote branch from f7c1aad to 887b29b Compare June 10, 2021 13:57
@cruessler cruessler force-pushed the show-symbol-if-tag-not-on-remote branch from 887b29b to 19d5fac Compare June 10, 2021 13:57
@cruessler
Copy link
Contributor Author

You’re right, spawning the async job inside if self.missing_remote_tags.is_none() was not thought through. I removed the conditional and put the call to spawn inside open, so now the missing tags are refreshed every time the popup is opened.

@extrawurst
Copy link
Owner

works great now! 👍

@extrawurst extrawurst merged commit 0fa3e0f into extrawurst:master Jun 12, 2021
@extrawurst extrawurst mentioned this pull request Jun 13, 2021
2 tasks
@cruessler cruessler deleted the show-symbol-if-tag-not-on-remote branch June 14, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants