Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silently throwing exceptions in performCorrectiveRecoding #98

Closed
eyalroz opened this issue Aug 12, 2023 · 1 comment
Closed

Silently throwing exceptions in performCorrectiveRecoding #98

eyalroz opened this issue Aug 12, 2023 · 1 comment
Assignees
@eyalroz
Labels
bug Something isn't working compatibility
Milestone
Thunderbird 91 co...

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 12, 2023

Ever since we've started using TextEncoder and TextDecoder, we have been throwing exceptions in our encode-correct-decode flow in performCorrectiveRecoding(); but these have been silently discarded - since we wanted to avoid decoding failures showing up as exceptions. Now that I've noticed these - let's fix them.
@eyalroz eyalroz added bug Something isn't working compatibility labels Aug 12, 2023
@eyalroz eyalroz self-assigned this Aug 12, 2023
@eyalroz eyalroz added this to the Thunderbird 91 compatibility milestone Aug 12, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Sep 1, 2023

This is apparently resolved by commit a12055a .

@eyalroz eyalroz closed this as completed Sep 1, 2023
@eyalroz eyalroz mentioned this issue Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug Something isn't working compatibility
Projects
None yet
Milestone
Thunderbird 91 compatibility
Development

No branches or pull requests
1 participant
@eyalroz