Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block dimension validation is comparing in the wrong direction #550

Closed
eyalroz opened this issue Oct 7, 2023 · 0 comments
Closed

Block dimension validation is comparing in the wrong direction #550

eyalroz opened this issue Oct 7, 2023 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 7, 2023

As noted in #545 , when validation is performed fully, we get an error for valid block sizes, e.g. 32, as supposedly being too large. This is due to a wrong direction of comparison in the check() lambda within cuda::detail_::validate_block_dimension_compatibility(). Let's fix that. Or rather, we already have, and let's mark it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant