Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't assume containers have cbegin() #553

Closed
eyalroz opened this issue Oct 17, 2023 · 0 comments
Closed

Shouldn't assume containers have cbegin() #553

eyalroz opened this issue Oct 17, 2023 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 17, 2023

The span container doesn't have a .cbegin() metho in all C++ versions; and specifically - our cuda::span doesn't. And yet, our code in program.hpp, add_headers(), line 366 - we assume it exists,. We need to drop that assumption, use begin() and end()`, and burden the user with ensuring the range/container they provide lets us use that.

@eyalroz eyalroz added the bug label Oct 17, 2023
@eyalroz eyalroz changed the title Assuming containers have cbegin() Shouldn't assume containers have cbegin() Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant