Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo list for Windows from Reddit #8

Closed
eyedeekay opened this issue Nov 21, 2018 · 2 comments
Closed

Todo list for Windows from Reddit #8

eyedeekay opened this issue Nov 21, 2018 · 2 comments

Comments

@eyedeekay
Copy link
Owner

eyedeekay commented Nov 21, 2018

  1. Do not show the Firefox location page if the installation has been successfully detected [done]
  2. Try to detect the I2P installation location, prompt the user if auto-detection fails (this is needed for a later step) [partial. It detects the installation directory and presents the menu, but does not cancel the menu and I can't seem to make it do that.] It is just the one extra click though. The message on the page has been altered to reflect that it can likely be clicked through.
  3. Add a last page with an option to launch the I2P browser after installer exits [done]
  4. Bypass the .bat files and create .lnk directly to the firefox executable, or somehow get rid of the command prompt windows the .bat files open [done] .bat files exit after launching firefox now, but have not been removed.
  5. Edit the clients.config file in the I2P installation folder so that when the user launches I2P, it will open the Firefox profile instead of the system default browser [done]
  6. Internationalization. This is potentially very big, but at least the skeleton of the infrastructure needs to be there so that as translators do their thing we can just add the translated strings [Seek Clarification:] 08e0898 The latest change removes English-language strings from the main nsi script into an 'include'd script that just declares those variables. It's simple enough to switch between them, but I simply don't know enough about NSIS to do this effectively at this time.
    NSIS Strings on SO1
    MUI2 seems to have facilities for this
@eyedeekay
Copy link
Owner Author

I just want to record for posterity how hard I laughed when I made my way here, number 5. http://docs.i2p-projekt.de/javadoc/net/i2p/apps/systray/ConfigFile.html

@eyedeekay
Copy link
Owner Author

Closed except for six, which is now it's own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant