Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would like setup.py with defined entry_points etc #32

Closed
kmpm opened this issue Jan 2, 2019 · 7 comments
Closed

would like setup.py with defined entry_points etc #32

kmpm opened this issue Jan 2, 2019 · 7 comments
Assignees

Comments

@kmpm
Copy link
Collaborator

kmpm commented Jan 2, 2019

I would like to have someway to do a proper install of this and if entry_points are defined one could get, for example, a trade.exe that works on windows.
If the package were published on pypi it could even be installed by pip (yay).

I can imagine that this will be difficult without moving code into a namespace for the package.

This is a wish from my side and a question if you would like some help with it.

@eyeonus
Copy link
Owner

eyeonus commented Feb 7, 2019

So, build isn't working, and I've lost patience trying to figure out why.

https://travis-ci.org/eyeonus/Trade-Dangerous/builds/489942291

Also, for some reason it didn't update the PR with my commits, so I had to issue a new PR, which is annoying.

@kmpm
Copy link
Collaborator Author

kmpm commented Feb 7, 2019

I'll have a look at the travis stuff

@kmpm
Copy link
Collaborator Author

kmpm commented Feb 9, 2019

Looking at the output in travis I spotted that the env variable GH_TOKENS is set but not GH_TOKEN which semantic-release needs.

Setting environment variables from repository settings
$ export GH_TOKENS=[secure]
$ export PYPI_PASSWORD=[secure]
$ export PYPI_USERNAME=[secure]

https://python-semantic-release.readthedocs.io/en/latest/automatic-releases/index.html#configuring-push-to-github

@eyeonus
Copy link
Owner

eyeonus commented Feb 9, 2019

#46 (comment)

Requires

* GH_TOKENS,  PYPI_USERNAME, PYPI_PASSWORD to be set in Travis

@eyeonus
Copy link
Owner

eyeonus commented Feb 9, 2019

Okay. It's finally working.

@eyeonus eyeonus closed this as completed Feb 9, 2019
eyeonus pushed a commit that referenced this issue Feb 9, 2019
This and previous commits combined fixes #32
@kmpm
Copy link
Collaborator Author

kmpm commented Feb 9, 2019

Sorry for that.

@eyeonus
Copy link
Owner

eyeonus commented Feb 9, 2019

Okay, now to work on the listener. Got to make it work with the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants