Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable for tdb.dataPath #48

Closed
Tromador opened this issue Feb 14, 2019 · 4 comments
Closed

Add environment variable for tdb.dataPath #48

Tromador opened this issue Feb 14, 2019 · 4 comments
Labels
enhancement New feature or request low priority Will be worked on when time is available

Comments

@Tromador
Copy link
Collaborator

I know we previously discussed this, but given the change to a pip model, I think we should switch up from this hardcoded

    self.dataPath = tdb.dataPath / Path("eddb")

to having a default (as above) but overridable with a $ENV. It will still only be relevant for server operation, I would think, but with automated upgrades, I think it's the right way to deal with it from now on.

@Tromador Tromador added enhancement New feature or request low priority Will be worked on when time is available labels Feb 14, 2019
@eyeonus
Copy link
Owner

eyeonus commented Feb 14, 2019 via email

@Tromador
Copy link
Collaborator Author

I am talking about the eddb subfolder. On the server I redirect that into the web accessible part of the file heirarchy,

e.g.

self.dataPath = tdb.dataPath / Path("/home/elite/public_html/files")

@Tromador
Copy link
Collaborator Author

My ISP have (in their infinite wisdom) forgotten that I have a fixed IP and so now I can't connect through the office firewall as my IP has randomised.

So I'll get this rolled out tomorrow and go live on the new server once I can (again) get shell access.

@eyeonus
Copy link
Owner

eyeonus commented Feb 14, 2019

So, the env-var is TD_EDDB once Travis finishes building the latest commit.

@eyeonus eyeonus closed this as completed Feb 14, 2019
eyeonus referenced this issue Feb 14, 2019
python-semantic-release automatic version update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Will be worked on when time is available
Projects
None yet
Development

No branches or pull requests

2 participants