Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this still working or obsolete #76

Closed
facade11663 opened this issue Jul 25, 2020 · 7 comments
Closed

is this still working or obsolete #76

facade11663 opened this issue Jul 25, 2020 · 7 comments
Labels
invalid This doesn't seem right not a bug Intended functionality, or user error

Comments

@facade11663
Copy link

facade11663 commented Jul 25, 2020

I only ask because my first "run" started with selling at a 4k loss with the return trip purchasing a commodity not sold at that station I tried updating the station info but the route was unchanged

input:
trade run --cap 96 --cr 13m --from "diaguandri/ray gateway" --loop --ly-per 20 -v

output:
Diaguandri/Ray Gateway -> Diaguandri/Ray Gateway (score: 509872.828430)
Load from Diaguandri/Ray Gateway: 95 x Chemicals/Agronomic Treatment (@4669cr), 1 x Textiles/Military Grade Fabrics (@2241cr),
Dock at Wolf 1297/Ivins Depot
Load from Wolf 1297/Ivins Depot: 96 x Metals/Gold (@8986cr),
Dock at Diaguandri/Ray Gateway
Finish Diaguandri/Ray Gateway + 1,018,583cr (5,305cr/ton)=> 14,018,583cr

actual:

#! trade.py import -
# Created by E:D Market Connector 4.0.3 on Windows for Cmdr facadekitsune.
#
#    <item name>             <sellCR> <buyCR>   <demand>   <stock>  <timestamp>

@ Wolf 1297/Ivins Depot
   + Chemicals
      Tritium                   42314   42776          ?       75L  2020-07-25 16:42:21
   + Machinery
      Power Generators           1781       0     38300H         -  2020-07-25 16:42:21
      Water Purifiers            2043       0     13668H         -  2020-07-25 16:42:21
   + Technology
      H.E. Suits                 1987       0    301200H         -  2020-07-25 16:42:21
   + Waste
      Chemical Waste               74       0       603H         -  2020-07-25 16:42:21
      Scrap                        78       0      1059H         -  2020-07-25 16:42:21


@eyeonus eyeonus added invalid This doesn't seem right not a bug Intended functionality, or user error labels Jul 25, 2020
@eyeonus eyeonus closed this as completed Jul 25, 2020
@eyeonus
Copy link
Owner

eyeonus commented Jul 25, 2020

Accuracy of station information is not guaranteed, as it is constantly changing, for every station.

This is why TD includes an "age" field, so that you know how old, and therefore how inaccurate, the data for that station is, and an --age option, so you can ignore data that is older and therefore more inaccurate.

>trade run --help
.
.
.
 --age DAYS, --max-days-old DAYS, -MD DAYS
                        Maximum age (in days) of trade data to use.

@eyeonus
Copy link
Owner

eyeonus commented Jul 25, 2020

>trade run --cap 96 --cr 13m --from "diaguandri/ray gateway" --loop --ly-per 20 -vvv
Diaguandri/Ray Gateway -> Diaguandri/Ray Gateway (score: 520126.151079)
Start CR: 13,000,000
Hops    :          2
Jumps   :          4
Gain CR :    983,216
Gain/Hop:    491,608
Final CR: 13,983,216

  Load from Diaguandri/Ray Gateway (479ls, BMk:Y, Pad:L, Plt:N, Flc:N, Shp:Y, Out:Y, Ref:Y):
       88 x Chemicals/Agronomic Treatment      4,669cr vs   13,021cr, <1 hr vs <1 hr, total:    410,872cr
        8 x Textiles/Military Grade Fabrics    2,229cr vs    4,735cr, <1 hr vs <1 hr, total:     17,832cr
  Unload at Pardian/Sharma Landing (105ls, BMk:N, Pad:M, Plt:N, Flc:N, Shp:N, Out:N, Ref:Y) => Gain 755,024cr (7,864.83cr/ton) => 13,755,024cr
  Load from Pardian/Sharma Landing (105ls, BMk:N, Pad:M, Plt:N, Flc:N, Shp:N, Out:N, Ref:Y):
       96 x Metals/Gold                        8,668cr vs   11,045cr, <1 hr vs <1 hr, total:    832,128cr
  Unload at Diaguandri/Ray Gateway (479ls, BMk:Y, Pad:L, Plt:N, Flc:N, Shp:Y, Out:Y, Ref:Y) => Gain 228,192cr (2,377cr/ton) => 13,983,216cr
  ----------------------------------------------------------------------------
Finish at Diaguandri/Ray Gateway (479ls, BMk:Y, Pad:L, Plt:N, Flc:N, Shp:Y, Out:Y, Ref:Y) gaining 983,216cr (5,120cr/ton) => est 13,983,216cr total

@facade11663
Copy link
Author

facade11663 commented Jul 26, 2020 via email

@eyeonus
Copy link
Owner

eyeonus commented Jul 26, 2020

It's not. Your problems are most likely due to user error.

As I already showed you, running the exact same command on my TD copy results in a DIFFERENT route than yours.

Having a different route with the same input criteria means operating on different data.

Since I did a full update of my copy of TD's database before performing the same run you did, and got a different route, that means your database is using older information.

The only difference between my run and yours is that I did -vvv instead of -v so you can see the age data.
(Ex.: "88 x Chemicals/Agronomic Treatment 4,669cr vs 13,021cr, <1 hr vs <1 hr, total: 410,872cr")

>trade run --cap 96 --cr 13m --from "diaguandri/ray gateway" --loop --ly-per 20 -vvv
Diaguandri/Ray Gateway -> Diaguandri/Ray Gateway (score: 520126.151079)
Start CR: 13,000,000
Hops    :          2
Jumps   :          4
Gain CR :    983,216
Gain/Hop:    491,608
Final CR: 13,983,216

  Load from Diaguandri/Ray Gateway (479ls, BMk:Y, Pad:L, Plt:N, Flc:N, Shp:Y, Out:Y, Ref:Y):
       88 x Chemicals/Agronomic Treatment      4,669cr vs   13,021cr, <1 hr vs <1 hr, total:    410,872cr
        8 x Textiles/Military Grade Fabrics    2,229cr vs    4,735cr, <1 hr vs <1 hr, total:     17,832cr
  Unload at Pardian/Sharma Landing (105ls, BMk:N, Pad:M, Plt:N, Flc:N, Shp:N, Out:N, Ref:Y) => Gain 755,024cr (7,864.83cr/ton) => 13,755,024cr
  Load from Pardian/Sharma Landing (105ls, BMk:N, Pad:M, Plt:N, Flc:N, Shp:N, Out:N, Ref:Y):
       96 x Metals/Gold                        8,668cr vs   11,045cr, <1 hr vs <1 hr, total:    832,128cr
  Unload at Diaguandri/Ray Gateway (479ls, BMk:Y, Pad:L, Plt:N, Flc:N, Shp:Y, Out:Y, Ref:Y) => Gain 228,192cr (2,377cr/ton) => 13,983,216cr
  ----------------------------------------------------------------------------
Finish at Diaguandri/Ray Gateway (479ls, BMk:Y, Pad:L, Plt:N, Flc:N, Shp:Y, Out:Y, Ref:Y) gaining 983,216cr (5,120cr/ton) => est 13,983,216cr total

If your copy of TD is having issues, update TD using pip install --upgrade tradedangerous.
Update the database using trade import -P eddblink -O listings

Then try again.

@facade11663
Copy link
Author

facade11663 commented Jul 26, 2020 via email

@eyeonus
Copy link
Owner

eyeonus commented Jul 26, 2020

TD's data is updated by using the import command. Clicking the update button on EDMC, which is a completely different program that has nothing to do with TD, has no effect.

It is recommended to use the EDDBlink import plugin to update TD's database, as it pulls the latest daily data dump from EDDB as well as more recent data gathered from the EDDN network using a program running on Tromador's server I built specifically for that purpose.

Please read the manual before blaming the program for problems caused by your lack of knowledge.

@eyeonus
Copy link
Owner

eyeonus commented Jul 26, 2020

Also, stop replying to the email, it's spamming your posts with a metric ton of css formatting.

Repository owner locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right not a bug Intended functionality, or user error
Projects
None yet
Development

No branches or pull requests

2 participants