Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to depend on EyeJs? #23

Open
mielvds opened this issue Dec 6, 2022 · 4 comments
Open

Refactor to depend on EyeJs? #23

mielvds opened this issue Dec 6, 2022 · 4 comments

Comments

@mielvds
Copy link

mielvds commented Dec 6, 2022

A while ago, I splitted off the eye wrapper to modernize it and use it in some other project: https://github.com/mielvds/EyeJs
Back then, the logical follow-up was to create a PR that would remove this logic and import the EyeJs package (not sure that's the best name either), but I never got to it.

I'm opening this issue to not forget about it and also to check whether this is actually desired.

@RubenVerborgh
Copy link
Collaborator

Happy to make you a package owner. My original idea was that EyeServer would just expose both:

EyeServer/package.js

Lines 1 to 2 in 36b3e87

exports.Eye = require('./lib/eye');
exports.EyeServer = require('./lib/eyeserver');

But I'm not strongly opinionated either way.
And also squatted https://www.npmjs.com/org/eyereasoner for us just in case.

@mielvds
Copy link
Author

mielvds commented Dec 16, 2022

Nice move!

Joining packages makes total sense, it was just a necessity at the time. but then this repo would need a total upgrade and transform to typescript?

@RubenVerborgh
Copy link
Collaborator

True; let's leave that as future work 🙂
Or we can already start with having Eye as TypeScript and upgrade the rest later.

@mielvds
Copy link
Author

mielvds commented Jan 4, 2023

My plan was to make the Eye.js api backwards-compatible (reinstate the callbacks and such) so this repo wouldn't need any code changes and leave it at that for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants