Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests that exepect an envvar #31

Closed
wants to merge 1 commit into from

Conversation

noslouch
Copy link
Contributor

if MAPBOX_API_KEY is not set in the environment, test_pass_kwargs fails.

noticed this when trying to run tests locally. the D prefix defers to values already set in the environment.

you may not want to introduce a new dependency to your project (namely pytest-env), and I would understand that, but just thought I'd bring this to your attention with a suggested fix. take it or leave it! this is a very useful library. thanks!

if `MAPBOX_API_KEY` is not set in the environment, `test_pass_kwargs`
fails
@eyeseast
Copy link
Owner

It works if I add the --api-key option, so I'd rather do that than add a dependency. Thanks for catching this, though. I'll fix this on another branch.

@eyeseast eyeseast closed this Mar 16, 2022
@noslouch noslouch deleted the contrib-testing branch March 16, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants