Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCage option to CLI #39

Merged
merged 2 commits into from Oct 31, 2022
Merged

Add OpenCage option to CLI #39

merged 2 commits into from Oct 31, 2022

Conversation

sbscully
Copy link
Contributor

@sbscully sbscully commented Oct 29, 2022

I'm a contractor for OpenCage geocoder. We'd like to add an opencage option to the CLI. OpenCage is already available in geopy so I have just copied the existing geocoder code with the relevant options.

  • Added OpenCage as an option to CLI
  • Added OpenCage to README
  • Added OpenCage test to Makefile

@sbscully sbscully marked this pull request as ready for review October 31, 2022 10:28
@eyeseast
Copy link
Owner

Hi. This looks great. Happy to get this in.

I didn't know about OpenCage until the ticket was opened here, but it looks really promising.

@eyeseast eyeseast merged commit 846f683 into eyeseast:main Oct 31, 2022
@sbscully sbscully deleted the opencage branch October 31, 2022 14:23
@sbscully
Copy link
Contributor Author

Thanks @eyeseast!

@eyeseast eyeseast mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants