Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much darker background colors with pywal16 comapred to python-pywal arch package #31

Open
ghost opened this issue Feb 28, 2024 · 14 comments

Comments

@ghost
Copy link

ghost commented Feb 28, 2024

I switched to your pywal fork and i noticed that background colors are almost pitch black compared to python-pywal i was using before

Is there any way to make pywal16 behave like python-pywal
(I used VSCode as a example but this apllies to anything that sues @backgroundColor including my waybar and rofi presets)

python-pywal package from arch repo

image

pywal16 installed with pipx

images

@guillaumeboehm
Copy link
Contributor

guillaumeboehm commented Feb 29, 2024

Just throwing that here, I didn't check anything. But the goal of pywal16 is to have a wider range of colors, the backgroundColor in the original pywal is likely closer to color8 of pywal16 rather than color0. I'd say the solution for you if you want a lighter background color is to tap in color8 instead of backgroundColor? Otherwise it would simply turn the issue around for people that want a darker background color I think?

Although I get the issue of not being very iso with pywal, but I'm not sure that is the goal of the project.

@ghost
Copy link
Author

ghost commented Feb 29, 2024

@guillaumeboehm

This how color 8 looks like

image

Here is the template i use as well in case it's needed

@define-color foreground {foreground};
@define-color background {background};
@define-color cursor {cursor};

@define-color color0 {color0};
@define-color color1 {color1};
@define-color color2 {color2};
@define-color color3 {color3};
@define-color color4 {color4};
@define-color color5 {color5};
@define-color color6 {color6};
@define-color color7 {color7};
@define-color color8 {color8};
@define-color color9 {color9};
@define-color color10 {color10};
@define-color color11 {color11};
@define-color color12 {color12};
@define-color color13 {color13};
@define-color color14 {color14};
@define-color color15 {color15};

@guillaumeboehm
Copy link
Contributor

Maybe color generation could need some rework, but seeing that a partial or maybe full rewrite of the program is probably on the way. I'd say it can wait until then.

@niksingh710
Copy link

yep i have noticed that too.
but if i change engine to haishoku then it works a bit nice and doesn't tilt towards dark black.

@niksingh710
Copy link

@eylles is the background dark color is intentional?

@eylles
Copy link
Owner

eylles commented May 6, 2024

hmmm i barely changed anything about how colors are generated and adjusted, tho i think when sonjiku made the original pr he did make color[0] quite darker.

welp i guess it happened either here: e504c55 or here: 42efe31

hmmm interesting, the only change is with the wal backend that is now generating a darker bg color.

with my current wallapaper:
__deutschland_azur_lane_drawn_by_majiang__23ea09d95f83b9a3147de1a77be9222f

these are the values i get

pywal16
wal bg: #050509
colorthief bg: #08090f
pywal
wal bg: #11101d
colorthief bg: #08090f

tagging @BEST8OY since he also reported this.

welp i'll simply modify the wal backend to output a lighter color before it gets darkened by the generic adjust function, unless someone does want to also have the darker bg from wal as an option.

@niksingh710
Copy link

looking forward for the fix commit.
and for general info ig that everyone knows but pywal is now archived..... so now pywal-16 is going to be the standard replacement ig.

@eylles eylles closed this as completed in 2584c70 May 6, 2024
@BEST8OY
Copy link

BEST8OY commented May 8, 2024

hmmm i barely changed anything about how colors are generated and adjusted, tho i think when sonjiku made the original pr he did make color[0] quite darker.
tagging @BEST8OY since he also reported this.

still not the way I expect it to be!

image

@eylles eylles reopened this May 8, 2024
@eylles
Copy link
Owner

eylles commented May 8, 2024

Would you mind sharing your wallpaper so i can use it to check the color values first hand?

@niksingh710
Copy link

Would you mind sharing your wallpaper so i can use it to check the color values first hand?

image

I don't have the wallpaper used by @BEST8OY but the wallpaper i used for above is
ferns-green

in the above preview you can see that colors of nautilus are quite darker (better than before but still a bit darker)

using 3.5.3

@BEST8OY
Copy link

BEST8OY commented May 9, 2024

Would you mind sharing your wallpaper so i can use it to check the color values first hand?

AA1b1oTJ

@eylles
Copy link
Owner

eylles commented May 9, 2024

Thanks, will check and try to figure out where in the code the color 0 shades differ

@niksingh710
Copy link

niksingh710 commented May 13, 2024

pawel-czerwinski-b50h2dmA69Q-unsplash-73692
This is the image that should give a brownish background but it is giving a pitch black one.
image
image

I generate pywal colors for heroic and i use color0 -> backgroud as the background for the heroic launcher

@eylles
Copy link
Owner

eylles commented May 13, 2024

thanks, will have to use the 3 images to check exactly what is going on, haven't had much time to check and fix this since last friday catched a sprained ankle and got 2 things that i need to tend before going back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants