New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Much darker background colors with pywal16 comapred to python-pywal arch package #31
Comments
Just throwing that here, I didn't check anything. But the goal of pywal16 is to have a wider range of colors, the backgroundColor in the original pywal is likely closer to color8 of pywal16 rather than color0. I'd say the solution for you if you want a lighter background color is to tap in color8 instead of backgroundColor? Otherwise it would simply turn the issue around for people that want a darker background color I think? Although I get the issue of not being very iso with pywal, but I'm not sure that is the goal of the project. |
This how color 8 looks like Here is the template i use as well in case it's needed
|
Maybe color generation could need some rework, but seeing that a partial or maybe full rewrite of the program is probably on the way. I'd say it can wait until then. |
yep i have noticed that too. |
@eylles is the background dark color is intentional? |
hmmm i barely changed anything about how colors are generated and adjusted, tho i think when sonjiku made the original pr he did make color[0] quite darker. welp i guess it happened either here: e504c55 or here: 42efe31 hmmm interesting, the only change is with the wal backend that is now generating a darker bg color. these are the values i get
tagging @BEST8OY since he also reported this. welp i'll simply modify the wal backend to output a lighter color before it gets darkened by the generic adjust function, unless someone does want to also have the darker bg from wal as an option. |
looking forward for the fix commit. |
still not the way I expect it to be! |
Would you mind sharing your wallpaper so i can use it to check the color values first hand? |
I don't have the wallpaper used by @BEST8OY but the wallpaper i used for above is in the above preview you can see that colors of nautilus are quite darker (better than before but still a bit darker) using |
Thanks, will check and try to figure out where in the code the color 0 shades differ |
thanks, will have to use the 3 images to check exactly what is going on, haven't had much time to check and fix this since last friday catched a sprained ankle and got 2 things that i need to tend before going back to this. |
I switched to your pywal fork and i noticed that background colors are almost pitch black compared to python-pywal i was using before
Is there any way to make pywal16 behave like python-pywal
(I used VSCode as a example but this apllies to anything that sues @backgroundColor including my waybar and rofi presets)
python-pywal package from arch repo
pywal16 installed with pipx
The text was updated successfully, but these errors were encountered: