New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds a feature to provide a list of already added tags #7
feat: adds a feature to provide a list of already added tags #7
Conversation
@eyoeldefare please draft this PR for now... it has some bugs need to fix that |
@eyoeldefare I've fixed the encountered issue, and have done some more changes: Apart from this, your code was breaking if You can merge it, if you want to. LMK if you want to add something, I'll be happy to hear. |
Hey thanks for the contribution, I will review this soon. |
would be great if you push it to pub! |
1 similar comment
would be great if you push it to pub! |
I am a bit busy right now due to exam season. I can't promise you to push it to pub but will review it during spring break. |
@ondbyte till then, you can use my version... I've merged my changes to my forked repo's master branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the pr again. I was very busy until just today.
I think everything checks out here.
I will push this to master.
Merging this PR will close #6 and will add a feature where the user can set an initial list of tags, which might have been added previously.
This is personally tested by me.
And apart from implementing this feature, I've also updated the
README.md
accordingly and have modified the code a little bit (have made the if statements shorter). Also, I didn't notice while committing that Android studio has formatted the code, LMK if you want that like before.LMK, if any further change is required from my end. 🙂