Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO in yaml frontmatter is handled as no, which is false #16

Closed
Ezian opened this issue May 14, 2022 · 0 comments
Closed

NO in yaml frontmatter is handled as no, which is false #16

Ezian opened this issue May 14, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@Ezian
Copy link
Owner

Ezian commented May 14, 2022

Reproduce

---
terrain:
    type: grassland
    mixed:
        - type: lake
          sides:
            - NO
---

In this case, script will fails and the map won't be generated

How to fix it

Retained solution is to use english cardinal direction (West instead of Ouest). NO will be no more an issue.

But in order to don't require a major update (it's kind of early to update the major version), we shouldn't introduce breaking changes. So Old way to write cardinal should be accepted, but deprecated (generate an error message, but handle it).

@Ezian Ezian added the bug Something isn't working label May 14, 2022
@Ezian Ezian added this to the v1.1.0 milestone May 14, 2022
Ezian pushed a commit that referenced this issue May 14, 2022
Ezian pushed a commit that referenced this issue May 14, 2022
@Ezian Ezian closed this as completed in d596b5e May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant