Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cache directory to node_modules #133

Closed
znck opened this issue Jan 17, 2019 · 4 comments · Fixed by #167
Closed

Move cache directory to node_modules #133

znck opened this issue Jan 17, 2019 · 4 comments · Fixed by #167
Labels
controversial kind: feature New feature or request kind: optimization Performance, space, size, etc improvement

Comments

@znck
Copy link

znck commented Jan 17, 2019

It's common practice to use node_modules/.cache/[namespace] as cache directory.

Benefits of having a cache directory in node_modules:

  1. No need to update .gitignore as node_modules is always ignored.
  2. It invisible to users.
@ezolenko
Copy link
Owner

Sounds reasonable, looks like some of the cool kids are using it, but it looks like there are objections?
sindresorhus/find-cache-dir#1
jestjs/jest#2303

@ezolenko ezolenko added kind: feature New feature or request controversial labels Jan 18, 2019
@ezolenko
Copy link
Owner

Can be overriden with cacheRoot option, but at that point user is already involved and both benefits are moot.

@znck
Copy link
Author

znck commented Jan 19, 2019

What I'm suggesting is an invisible cache directory, which exists but you don't care about it.

@ForsakenHarmony
Copy link

We're doing this in microbundle now

@nickmccurdy nickmccurdy mentioned this issue Aug 20, 2019
Merged
Repository owner locked as resolved and limited conversation to collaborators May 7, 2022
@agilgur5 agilgur5 added the kind: optimization Performance, space, size, etc improvement label May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
controversial kind: feature New feature or request kind: optimization Performance, space, size, etc improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move cache directory to node_modules nickmccurdy/rollup-plugin-typescript2
4 participants
@ezolenko @znck @agilgur5 @ForsakenHarmony