Update vsphere_vm_clone.rb #114
Conversation
Adding windows support
|
Can you please reformat this with spaces instead of tabs? Most (all?) of this code is written with 2 spaces per tab. |
|
L Must be the copy and paste, hold on From: Eli Klein [mailto:notifications@github.com] Can you please reformat this with spaces instead of tabs? Most (all?) of this code is written with 2 spaces per tab. — |
|
Sorry my comment may have been confusing. The file you submitted has a lot of tabs in it instead of spaces. If you can use spaces instead of tabs and then simply format the whole file in an editor using 2 spaces per tab, this should clean up nicely. |
|
I already understood it J It is a mess now, strange that I didn’t see it before. I will fix it now From: Eli Klein [mailto:notifications@github.com] Sorry my comment may have been confusing. The file you submitted has a lot of tabs in it instead of spaces. If you can use spaces instead of tabs and then simply format the whole file in an editor using 2 spaces per tab, this should clean up nicely. — |
|
No worries, thanks for fixing! |
|
Does this look beter? From: Eli Klein [mailto:notifications@github.com] No worries, thanks for fixing! — |
|
I don't see any changes yet.. |
|
I attached the file in the mail ;) From: Eli Klein [mailto:notifications@github.com] I don't see any changes yet.. — |
Changed tabs to spaces and cleanup
|
So if you just force push this new file on top of your branch, it should come through in GH. I think it looks good though :) |
|
Looks great. Let me review one last time and then I'll merge. |
|
Cool thnx! From: Eli Klein [mailto:notifications@github.com] Looks great. Let me review one last time and then I'll merge. — |
|
oops meant to leave this comment here... I just pulled down your code and installed it to test. It appears you haven't added these new dependencies to the gemspec. Please add any dependencies you need to the gemspec and I can give it another shot once those are in there. Thanks! |
|
Eli, Im a bit new on this so if you can help me out that would be great. The only thing it is relying on is knife-windows. I dont have any chef servers anymore so im unable to test it.
|
| end | ||
| clone_spec.customization = cust_spec |
There was a problem hiding this comment.
Please move this line above if statement as it was done in Issue#101. Otherwise customization plugin cannot change attributes set by customization file.
BTW, on which OS versions did you test this code?
There was a problem hiding this comment.
Redhat 6.0 but without cust spec file and windows 2008 r2
On Jun 12, 2014, at 20:14, valldeck notifications@github.com wrote:
In lib/chef/knife/vsphere_vm_clone.rb:
end
- clone_spec.customization = cust_spec
Please move this line above if statement as it was done in Issue#101. Otherwise customization plugin cannot change attributes set by customization file.BTW, on which OS versions did you test this code?
—
Reply to this email directly or view it on GitHub.
|
Any luck yet? |
|
Any plans to merge this in? |
|
I plan to catch up on merges and branch sometime over the next two weeks. Stay tuned...
|
|
I ended up resolving the merge and doing a major cleanup fixing of this code as such this pull request is encompassed inside my new pull request #137 |
|
@ezrapagel 4 months later any sign of life ? |
|
I've been helping out with some of the reviews but I've got no way of testing this request. I can see that the request to add files to the gemspec were never addressed. #137 looks promising but again, no ability for me to test. |
|
Closing as it was incorporated into #137. Thanks for giving us the leg up on this code. |
Adding windows support