Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-float can be removed when using #72

Closed
ghuls opened this issue Sep 14, 2021 · 3 comments
Closed

fast-float can be removed when using #72

ghuls opened this issue Sep 14, 2021 · 3 comments

Comments

@ghuls
Copy link
Contributor

ghuls commented Sep 14, 2021

fast-float can be removed when using a recent rust compiler. Similar algoritm now in standard library:
https://www.reddit.com/r/rust/comments/omelz4/making_rust_float_parsing_fast_libcore_edition/
pola-rs/polars#1010

@ezrosent
Copy link
Owner

Thanks for the pointer! I'll double check and re-run some benchmarks but assuming all goes well I will remove the fast-float dependency and just use the standard library.

@ezrosent
Copy link
Owner

Hmm, we need partial parsing. I'm not sure if the standard library has this for f64. I'll look around some more.

@ezrosent
Copy link
Owner

Unfortunately I don't think I can remove the fast-float dependency because awk's string conversions work with any prefix to a string (parse_partial in fast-float). Thanks for the pointer though, this was good to read up on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants