Specify a custom port is not always possible across classes

[ozh]

Hi

Currently there is no consistent way across classes to specify a port.

• cubrid and postgresql constructor functions accept a port number as argument
• other classes don't explicitly accept a port argument. In these, some DB engines (mysql, mssql) accept a "hostname:port" notation (eg "localhost:3306") but some others (mysqli, pdo, sqlsrv) need specific stuff
• depending on the DB engine, you cannot simply use ezSQL at the moment if you use a non standard port

I'm willing to fix this inconsistency and to submit a pull request but I'm seeking for approval before I start coding :)

My idea would be to accept the "hostname:port" notation in all classes, to preserve the number and order of arguments in all constructors as they are now (and not to break any script that would update after you commit the PR)

Any thoughts?

[jv2222]

Yes please fix and submit a pull request thanks!

(Via iPhone)

On Aug 25, 2013, at 11:22 AM, ྅༻ Ǭɀħ ༄༆ཉ notifications@github.com wrote:

Hi

Currently there is no consistent way across classes to specify a port.

cubrid and postgresql constructor functions accept a port number as argument
other classes don't explicitly accept a port argument. In these, some DB engines (mysql, mssql) accept a "hostname:port" notation (eg "localhost:3306") but some others (mysqli, pdo, sqlsrv) need specific stuff
depending on the DB engine, you cannot simply use ezSQL at the moment if you use a non standard port
I'm willing to fix this inconsistency and to submit a pull request but I'm seeking for approval before I start coding :)

My idea would be to accept the "hostname:port" notation in all classes, to preserve the number and order of arguments in all constructors as they are now (and not to break any script that would update after you commit the PR)

Any thoughts?

—
Reply to this email directly or view it on GitHub.