Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31475: Added Badges to UIGuidelines v3.0 #970

Merged
merged 1 commit into from Mar 19, 2020
Merged

EZP-31475: Added Badges to UIGuidelines v3.0 #970

merged 1 commit into from Mar 19, 2020

Conversation

inakijv
Copy link
Contributor

@inakijv inakijv commented Mar 13, 2020

Question Answer
JIRA Ticket EZP-31475
Versions 3.0

Badges - eZ Platform Developer Documentation

@inakijv
Copy link
Contributor Author

inakijv commented Mar 13, 2020

Ping @ezsystems/documentation-team @dew326

@DominikaK DominikaK self-assigned this Mar 16, 2020
DominikaK
DominikaK approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@DominikaK DominikaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's an issue, but badges with icons have a weird baseline when previewed on Chrome:
image

@inakijv
Copy link
Contributor Author

inakijv commented Mar 18, 2020

@DominikaK they have both the same properties and rendering as the live application

@DominikaK DominikaK merged commit a30e35c into ibexa:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@DominikaK DominikaK DominikaK approved these changes

Assignees

@DominikaK DominikaK

Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
3 participants
@inakijv @dew326 @DominikaK