Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling edge case of empty view cache file #386

Merged
merged 1 commit into from Aug 6, 2012

Conversation

pkamps
Copy link
Contributor

@pkamps pkamps commented Aug 2, 2012

Alternative solution to this pull request:
#325

@bdunogier
Copy link
Member

It looks okay to me, I'd almost merge it right away.

Any counter opinion ?

@nfrp
Copy link
Contributor

nfrp commented Aug 2, 2012

@bdunogier : you are the Clustering boss, I can only follow your recommendation here. Is this fix also fixing @alexpagnoni 's issue ?

Thanks for the contributions @pkamps !

@pkamps
Copy link
Contributor Author

pkamps commented Aug 2, 2012

Yes - you want to merge only one of the two pull requests.

@bdunogier
Copy link
Member

Well, an empty cache file will generate an error when it gets parsed by the
ViewCache handler, so yes, I would say it fixes it as well.

It would be great if Alex could comment, though, but the time may not be
the best :-)
Le 2 août 2012 19:11, "Nicolas Pastorino" <
reply@reply.github.com>
a écrit :

@bdunogier : you are the Clustering boss, I can only follow your
recommendation here. Is this fix also fixing @alexpagnoni 's issue ?

Thanks for the contributions @pkamps !


Reply to this email directly or view it on GitHub:
#386 (comment)

@nfrp
Copy link
Contributor

nfrp commented Aug 3, 2012

+1 for a merge then.
@alexpagnoni can step-in even afterwards to confirm whether the fix works in his case too, or not.

@pkamps
Copy link
Contributor Author

pkamps commented Aug 3, 2012

He mentioned that they changed their setup - I'm not sure if he'll be able to confirm it.

@nfrp
Copy link
Contributor

nfrp commented Aug 6, 2012

Ok.
Merging now.

nfrp added a commit that referenced this pull request Aug 6, 2012
Fixed/Improved: Handling edge case of empty view cache file (alternative fix to #325)
@nfrp nfrp merged commit 18ffd7f into ezsystems:master Aug 6, 2012
@nfrp
Copy link
Contributor

nfrp commented Aug 6, 2012

Thank you Philipp for the contribution!
And thanks Bertrand for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants