Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghstack land merges PR even if master push fails (e.g., because it's protected) #51

Closed
ezyang opened this issue Mar 12, 2021 · 1 comment
Closed

ghstack land merges PR even if master push fails (e.g., because it's protected) #51

ezyang opened this issue Mar 12, 2021 · 1 comment

Comments

@ezyang
Copy link
Owner

ezyang commented Mar 12, 2021

This is because of the order of operations: we have to merge the PR first otherwise the pushed commit will close it. But that means that if the push actually fails then you have a merged PR but not actually getting to master.
@ezyang
Copy link
Owner Author

ezyang commented Dec 2, 2023

Ameliorated by manual check to ensure branch is not protected

@ezyang ezyang closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ezyang