Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amending commit message would not update PR description #7

Closed
xuhdev opened this issue Aug 1, 2019 · 4 comments
Closed

Amending commit message would not update PR description #7

xuhdev opened this issue Aug 1, 2019 · 4 comments

Comments

@xuhdev
Copy link

xuhdev commented Aug 1, 2019

If I run

git commit --amend

and modify the commit message, running ghstack would change the commit message back to the previous version and not update the PR description.

@ezyang
Copy link
Owner

ezyang commented Aug 1, 2019

This is by design, since it is very common for people to edit PR descriptions after the fact. Use ghstack --update-fields to clobber the PR description.

@ezyang ezyang closed this as completed Aug 1, 2019
@Zacharias030
Copy link

Is there a way to use --update-fields only on a specific commit of my stack?
Often the first commit is where I introduce the whole stack in the PR description and then I want to "push" the changed commit message of some commit downstream of that.

@ezyang
Copy link
Owner

ezyang commented Dec 10, 2021

No, but this is a feature that is worth supporting, along with generally letting people update only a single commit on their stack. Feel free to open an issue about it.

@xuhdev
Copy link
Author

xuhdev commented Dec 10, 2021

I always run git rebase -i HEAD~N to edit a single commit. See https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants