Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put ghstack message below commit message body / update local message with remote #86

Closed
thorbenprimke opened this issue Oct 6, 2021 · 2 comments

Comments

@thorbenprimke
Copy link

Just another observation from using it - enjoying ghstack more every day. :)

I was wondering if there is a (technical) reason that the ghstack info is inserted above the commit message? Maybe it could be a config to either inject the stack info above or below the message.

Screen Shot 2021-10-06 at 10 14 24 AM

And I was curious if amending the local commit message with remote changes has come up in the past? The use case here is that I/we often add screenshots to a commit on github.com directly. When I update the commit by running ghstack again, the remote edits are overwritten.

That's all - one of these days I have to take an afternoon to work on these improvements. ;)

@ezyang
Copy link
Owner

ezyang commented Oct 6, 2021

I was wondering if there is a (technical) reason that the ghstack info is inserted above the commit message?

There is no technical reason. An aesthetic reason for placing it up top is when you navigate between PRs, the stack list stays at a fixed position (like a menubar). If you want to add a config to toggle it, I guess it's OK; it doesn't seem like the payoff is that great though, but it's pretty simple.

And I was curious if amending the local commit message with remote changes has come up in the past? The use case here is that I/we often add screenshots to a commit on github.com directly. When I update the commit by running ghstack again, the remote edits are overwritten.

Ah yes, this should exist as a feature, it just hasn't been written. Please implement it as ghstack sync [--stack] (stack argument to update all commits in your stack).

@ezyang
Copy link
Owner

ezyang commented Dec 2, 2023

Duping it as #67

@ezyang ezyang closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants