Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: semantic release #339

Merged
merged 2 commits into from Sep 18, 2022
Merged

fix: semantic release #339

merged 2 commits into from Sep 18, 2022

Conversation

bytestream
Copy link
Contributor

I noticed that 523407f didn't update all the files:

'VERSION',
'NEWS',
'Doxyfile',
'library/HTMLPurifier.php',
'library/HTMLPurifier/Config.php',
'library/HTMLPurifier.includes.php'

I believe this PR fixes that. Here's an example I ran locally - the important bit being Update /v/NEWS and Found 6 file(s) to commit:

$ npx semantic-release --no-ci
[6:41:28 PM] [semantic-release] › ℹ  Running semantic-release version 19.0.5
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@semantic-release/changelog"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "verifyConditions" from "@semantic-release/git"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "analyzeCommits" from "@semantic-release/commit-analyzer"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "analyzeCommits" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "verifyRelease" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "generateNotes" from "@semantic-release/release-notes-generator"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "generateNotes" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "prepare" from "@semantic-release/changelog"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "prepare" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "prepare" from "@semantic-release/git"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "publish" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "addChannel" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "success" from "@semantic-release/exec"
[6:41:28 PM] [semantic-release] › ✔  Loaded plugin "fail" from "@semantic-release/exec"
[6:41:30 PM] [semantic-release] › ✔  Run automated release from branch master on repository https://github.com/bytestream/htmlpurifier
[6:41:31 PM] [semantic-release] › ✔  Allowed to push to the Git repository
[6:41:31 PM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "@semantic-release/changelog"
[6:41:31 PM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@semantic-release/changelog"
[6:41:31 PM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ℹ  Start step "verifyConditions" of plugin "@semantic-release/git"
[6:41:31 PM] [semantic-release] › ✔  Completed step "verifyConditions" of plugin "@semantic-release/git"
[6:41:31 PM] [semantic-release] › ℹ  Found git tag v4.16.0 associated with version 4.16.0 on branch master
[6:41:31 PM] [semantic-release] › ℹ  Found 1 commits since last release
[6:41:31 PM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[6:41:31 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: fix: foobar
[6:41:31 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The release type for the commit is patch
[6:41:31 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 1 commits complete: patch release
[6:41:31 PM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[6:41:31 PM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ℹ  The next release version is 4.16.1
[6:41:31 PM] [semantic-release] › ℹ  Start step "verifyRelease" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ✔  Completed step "verifyRelease" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[6:41:31 PM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[6:41:31 PM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] › ℹ  Start step "prepare" of plugin "@semantic-release/changelog"
[6:41:31 PM] [semantic-release] [@semantic-release/changelog] › ℹ  Update /v/NEWS
[6:41:31 PM] [semantic-release] › ✔  Completed step "prepare" of plugin "@semantic-release/changelog"
[6:41:31 PM] [semantic-release] › ℹ  Start step "prepare" of plugin "@semantic-release/exec"
[6:41:31 PM] [semantic-release] [@semantic-release/exec] › ℹ  Call script php update-for-release 4.16.1
+++ dirname maintenance/flush.sh
++ cd maintenance
++ pwd
+ DIR=/v/maintenance
+ php /v/maintenance/generate-includes.php
Scanning for files... done!
Writing HTMLPurifier.includes.php... done!
Writing HTMLPurifier.safe-includes.php... done!
+ php /v/maintenance/generate-schema-cache.php
Saving schema... done!
+ php /v/maintenance/flush-definition-cache.php
Flushing cache... 
 - Flushing HTML
 - Flushing CSS
 - Flushing URI
 - Flushing Test
Cache flushed successfully.
+ php /v/maintenance/generate-standalone.php
Generating includes file... done!
Creating full file... done!
Creating standalone directory... done!
+ php /v/maintenance/config-scanner.php
PHP Fatal error:  Uncaught Error: Class 'XMLWriter' not found in /v/maintenance/config-scanner.php:132
Stack trace:
#0 {main}
  thrown in /v/maintenance/config-scanner.php on line 132

136/139 instances of $config or $this->config found in source code.
Generating XML... Review changes, and then commit with log 'Release 4.16.1.'
[6:41:32 PM] [semantic-release] › ✔  Completed step "prepare" of plugin "@semantic-release/exec"
[6:41:32 PM] [semantic-release] › ℹ  Start step "prepare" of plugin "@semantic-release/git"
[6:41:32 PM] [semantic-release] [@semantic-release/git] › ℹ  Found 6 file(s) to commit
[6:41:34 PM] [semantic-release] [@semantic-release/git] › ℹ  Prepared Git release: v4.16.1
[6:41:34 PM] [semantic-release] › ✔  Completed step "prepare" of plugin "@semantic-release/git"
[6:41:34 PM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[6:41:34 PM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[6:41:34 PM] [semantic-release] › ℹ  Start step "generateNotes" of plugin "@semantic-release/exec"
[6:41:34 PM] [semantic-release] › ✔  Completed step "generateNotes" of plugin "@semantic-release/exec"
[6:41:36 PM] [semantic-release] › ✔  Created tag v4.16.1
[6:41:36 PM] [semantic-release] › ℹ  Start step "publish" of plugin "@semantic-release/exec"
[6:41:36 PM] [semantic-release] › ✔  Completed step "publish" of plugin "@semantic-release/exec"
[6:41:36 PM] [semantic-release] › ℹ  Start step "success" of plugin "@semantic-release/exec"
[6:41:36 PM] [semantic-release] › ✔  Completed step "success" of plugin "@semantic-release/exec"
[6:41:36 PM] [semantic-release] › ✔  Published release 4.16.1 on default channel

@ezyang ezyang merged commit d82f3d9 into ezyang:master Sep 18, 2022
github-actions bot pushed a commit that referenced this pull request Sep 18, 2022
## [4.16.1](v4.16.0...v4.16.1) (2022-09-18)

### Bug Fixes

* semantic release ([#339](#339)) ([d82f3d9](d82f3d9))
@github-actions
Copy link

🎉 This PR is included in version 4.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ezyang
Copy link
Owner

ezyang commented Sep 18, 2022

Hmm, this looks like it checked in the standalone files. I'm going to revert

@ezyang
Copy link
Owner

ezyang commented Sep 18, 2022

4.16.1 was unmerged, and its version yanked from composer

ezyang added a commit that referenced this pull request Sep 18, 2022
ezyang added a commit that referenced this pull request Sep 18, 2022
'VERSION',
'NEWS',
'Doxyfile',
'library/**/*',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to exclude standalone here somehow, I think

bytestream added a commit to bytestream/htmlpurifier that referenced this pull request Sep 20, 2022
* fix: semantic release

* update git assets

(cherry picked from commit d82f3d9)
bytestream pushed a commit to bytestream/htmlpurifier that referenced this pull request Sep 20, 2022
bytestream pushed a commit to bytestream/htmlpurifier that referenced this pull request Sep 20, 2022
bytestream added a commit to bytestream/htmlpurifier that referenced this pull request Sep 20, 2022
* fix: semantic release

* update git assets

(cherry picked from commit d82f3d9)
bytestream pushed a commit to bytestream/htmlpurifier that referenced this pull request Sep 20, 2022
@bytestream bytestream mentioned this pull request Sep 20, 2022
bytestream pushed a commit to bytestream/htmlpurifier that referenced this pull request Sep 20, 2022
ezyang pushed a commit that referenced this pull request Sep 20, 2022
Same as #339 but stops library/standalone and library/HTMLPurifier.standalone.phpfrom being commit
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
# [4.17.0](v4.16.0...v4.17.0) (2023-11-17)

### Bug Fixes

* CSSTidy ImportantComments not handled properly ([#359](#359)) ([78a9b4d](78a9b4d))
* fix CI ([#361](#361)) ([9ec687c](9ec687c))
* Invalid scheme check in Attr.TargetBlank ([#363](#363)) ([0176ef4](0176ef4))
* semantic release ([#339](#339)) ([d82f3d9](d82f3d9))
* semantic release ([#341](#341)) ([e55fead](e55fead)), closes [#339](#339)
* Support for locales using decimal separators other than . (dot) ([#372](#372)) ([43f49ac](43f49ac))

### Features

* Add support for all text-decoration properties ([#360](#360)) ([2d775c0](2d775c0))
* Allows commas to be included in tel URI ([#389](#389)) ([ec92490](ec92490)), closes [#388](#388)

### Reverts

* Revert "fix: semantic release (#339)" (#340) ([3e83215](3e83215)), closes [#339](#339) [#340](#340)
Copy link

🎉 This PR is included in version 4.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants